-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix): Set formData
as action
span data.
#10836
Conversation
formData
as span data.formData
as action
span data.
470ce9e
to
3cd1fd2
Compare
dev-packages/e2e-tests/test-applications/create-remix-app-express/event-proxy-server.ts
Fixed
Show fixed
Hide fixed
cf0b64f
to
3e92cda
Compare
873a5a1
to
f0490ab
Compare
size-limit report 📦
|
8145fb2
to
6ba3dc0
Compare
d225fcb
to
5d458fe
Compare
action_form_data_test: 'test', | ||
action_form_data_file: 'file.txt', | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add the test I added here (or a similar one):
ad7601f
to
e131585
Compare
92f3e76
to
954ac65
Compare
/* Run your local dev server before starting the tests */ | ||
webServer: [ | ||
{ | ||
command: 'pnpm tsx start-event-proxy.ts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to switch to tsx
from ts-node
after hitting TypeStrong/ts-node#1997 and spending hours just to fail to resolve it.
954ac65
to
f2a604b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more change and then we can merge!
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
0c33e85
to
c6980e4
Compare
c6980e4
to
31fa545
Compare
Resolves: #10238
Clones the
request
inaction
to readformData
and sets each entry as an attribute to theaction
span.Also adds a new e2e test application using latest Remix with Express, which both tests server and client-side.
There seem to be a few limitations regarding the availability of complete data (multiple file uploads from a single input for example), but I think we can consider this as the best effort.
This will only work when
sendDefaultPii
is set totrue
, but we can also add another option to control this.